[MEAR-159] encoding when filtering resources

[jira-importer]

Aleksey Kaigorodov opened MEAR-159 and commented

Resources of our ear project contain non-ascii characters. This xml-files in windows-1251. We use filtering resources when building ear.
Building in the dev environment (Windows, file.encoding = Cp1251) goes well. The build at the CI-server (Linux, file.encoding = UTF-8) non-ascii characters in xml-files are replaced with a sequence of bytes 'efbfbd'.

It would be convenient to be able to specify the encoding for the ear resources, similar to how we can do it in the maven-resources-plugin.

Sample project attached.

---

Affects: 2.8

Attachments:

• maven-ear-plugin-2.10-test-project-resources-encoding.zip (1.66 kB)
• maven-ear-plugin-test-project-resources-encoding.zip (1.36 kB)

Issue Links:

• MWAR-164 Support for specifying which encoding to use when filtering resources

[jira-importer]

Dennis Lundberg commented

I fixed a similar issue in Maven WAR Plugin 2.3.

[jira-importer]

Karl Heinz Marbaise commented

Is this true for 2.10 ?

[jira-importer]

Aleksey Kaigorodov commented

Yes, the problem is reproduced with 2.10

[jira-importer]

Aleksey Kaigorodov commented

An updated sample attached.

[jira-importer]

Karl Heinz Marbaise commented

Fixed in r1661423.

[jira-importer]

Karl Heinz Marbaise commented

Hi Alex, are you able to check an SNAPSHOT if the change is now doing what intended to be. Based on your example project i can say it works.
If i check the original file:

$ hexdump src/main/application/META-INF/test.xml
0000000 3c 3f 78 6d 6c 20 76 65 72 73 69 6f 6e 3d 22 31
0000010 2e 30 22 20 65 6e 63 6f 64 69 6e 67 3d 22 77 69
0000020 6e 64 6f 77 73 2d 31 32 35 31 22 3f 3e 0d 0a 3c
0000030 74 65 73 74 20 6e 61 6d 65 3d 22 d2 e5 f1 f2 22
0000040 2f 3e
0000042

and the created file with encoding set as in the example:

$ hexdump target/maven-ear-plugin-test-project-resources-encoding-99.0/META-INF/test.xml
0000000 3c 3f 78 6d 6c 20 76 65 72 73 69 6f 6e 3d 22 31
0000010 2e 30 22 20 65 6e 63 6f 64 69 6e 67 3d 22 77 69
0000020 6e 64 6f 77 73 2d 31 32 35 31 22 3f 3e 0d 0a 3c
0000030 74 65 73 74 20 6e 61 6d 65 3d 22 d2 e5 f1 f2 22
0000040 2f 3e
0000042

If i don't set the encoding in the pom file i will get a wrong result (which is based on the default encoding):

$ hexdump target/maven-ear-plugin-test-project-resources-encoding-99.0/META-INF/test.xml
0000000 3c 3f 78 6d 6c 20 76 65 72 73 69 6f 6e 3d 22 31
0000010 2e 30 22 20 65 6e 63 6f 64 69 6e 67 3d 22 77 69
0000020 6e 64 6f 77 73 2d 31 32 35 31 22 3f 3e 0d 0a 3c
0000030 74 65 73 74 20 6e 61 6d 65 3d 22 ef bf bd ef bf
0000040 bd ef bf bd ef bf bd 22 2f 3e
000004a

I have provided an development version which can be seen here:

Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/maven/plugins/maven-ear-plugin/2.11-SNAPSHOT/maven-ear-plugin-2.11-20150221.183218-97.jar
Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/maven/plugins/maven-ear-plugin/2.11-SNAPSHOT/maven-ear-plugin-2.11-20150221.183218-97.jar (90 KB at 31.9 KB/sec)
Uploading: https://repository.apache.org/content/repositories/snapshots/org/apache/maven/plugins/maven-ear-plugin/2.11-SNAPSHOT/maven-ear-plugin-2.11-20150221.183218-97.pom
Uploaded: https://repository.apache.org/content/repositories/snapshots/org/apache/maven/plugins/maven-ear-plugin/2.11-SNAPSHOT/maven-ear-plugin-2.11-20150221.183218-97.pom (10 KB at 4.1 KB/sec)