Fix #510: Propagate IOException instead of swallowing it in ApplicationXmlWriter.write()#523
Open
elharo wants to merge 1 commit into
Open
Fix #510: Propagate IOException instead of swallowing it in ApplicationXmlWriter.write()#523elharo wants to merge 1 commit into
elharo wants to merge 1 commit into
Conversation
…licationXmlWriter.write() Replace the empty catch block with a throw of EarPluginException wrapping the IOException, so build fails on IO errors instead of silently producing a truncated or missing application.xml. Adds unit test coverage for ApplicationXmlWriter: - Happy path: write to a valid temp file - Failure path: write to /dev/full triggers EarPluginException
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #510
Problem
In
ApplicationXmlWriter.write(), anyIOExceptionduring XML writing (e.g., disk full, permission denied) is silently swallowed:```java
} catch (IOException ex) {
// ignore
}
```
This means the EAR build succeeds with a truncated or missing
application.xmldeployment descriptor, making the failure undetectable.Changes
EarPluginExceptionwrapping theIOException.testWriteSucceedsToValidFile: happy path writing to a temp filetestWriteThrowsExceptionOnIoError: writing to/dev/fullassertsEarPluginExceptionis thrownVerification