Skip to content

Conversation

@ImadBL
Copy link

@ImadBL ImadBL commented Apr 25, 2022

Hi,

This concerns the maven-resources-plugin (3.2.1-SNAPSHOT) and maven-filtering (3.3.0-SNAPSHOT) plugins.
with this evolution it is now possible to add configuration files with json format. the second part of this evolution is to have to use a one configuration json file for all environments (dev, preprod, prod...etc )
for more example check: MRESOURCES-284

please note that you must accept the PR first for maven-filtering (3.3.0-SNAPSHOT)
because maven-resources-plugin (3.2.1-SNAPSHOT) need maven-filtering (3.3.0-SNAPSHOT)

if you have any questions do not hesitate, hoping that I have detailed well

Best regards
Imad BELMOUJAHID
@ImadBL

@olamy
Copy link
Member

olamy commented Jul 13, 2022

not sure we want to introduce such dependency on json...
maybe you should better have a look at this option https://maven.apache.org/plugins/maven-resources-plugin/examples/custom-resource-filters.html

@michael-o
Copy link
Member

not sure we want to introduce such dependency on json... maybe you should better have a look at this option https://maven.apache.org/plugins/maven-resources-plugin/examples/custom-resource-filters.html

I agree with you. This PR is logically incompatible with other setups and will break consistently.

@slachiewicz
Copy link
Member

so what alternative?

@elharo elharo changed the title Support JSON format for parameter filter files #MRESOURCES-284 [MRESOURCES-284] Support JSON format for parameter filter files Oct 22, 2023
@gnodet gnodet closed this Feb 26, 2024
@gnodet
Copy link
Contributor

gnodet commented Feb 26, 2024

A more suitable format (other than JSON) should be chosen as an alternative.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants