Skip to content

Conversation

@slachiewicz
Copy link
Member

No description provided.

@slachiewicz slachiewicz added the enhancement New feature or request label Sep 28, 2025
@slachiewicz slachiewicz merged commit 527fc79 into v4 Sep 28, 2025
120 checks passed
@slachiewicz slachiewicz deleted the jdk25 branch September 28, 2025 09:16
@slawekjaranowski
Copy link
Member

For JDK 25 we need an m-invoker-p in version 3.9.1 ... but in parent we have 3.9.0 ... so we need override it in all project or release next parent 😄

ff-jdk:
description: The jdk version used during fail-fast-build job
required: false
default: '17'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intention to build first built by JDK 17 ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're right, this was leftover but tbh we may keep 17 in FF.
My idea was that Java 11 and 17 are really stable.
21 is stable also and is usually the recommended version.
24 is lots but fresh and without tests with 21 we would not know if failure is related to changes in 25 only.

@hboutemy
Copy link
Member

For JDK 25 we need an m-invoker-p in version 3.9.1 ... but in parent we have 3.9.0 ... so we need override it in all project or release next parent

next time such a global issue is found, please don't break everything and let the whole team discover and manage locally

now I understand how much time I lost for nothing, I'm disgusted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants