[MGPG-44] gpg:sign fix non-default output directory#14
Closed
Giovds wants to merge 3 commits intoapache:masterfrom
Closed
[MGPG-44] gpg:sign fix non-default output directory#14Giovds wants to merge 3 commits intoapache:masterfrom
Giovds wants to merge 3 commits intoapache:masterfrom
Conversation
Submitted by: Giovanni van der Schelde Setting the output directory added an extra unnecessary /target directory. Applied a fix for this issue and mostly adding integration tests.
mthmulders
requested changes
Sep 7, 2021
mthmulders
left a comment
mthmulders
left a comment
There was a problem hiding this comment.
Overall, looks good to me, except for the potential flakiness of the test.
I am not too familiar with this plugin so I'd value a second opinion from someone who is more familiar with it.
src/test/java/org/apache/maven/plugins/gpg/it/GpgSignArtifactIT.java
Outdated
Show resolved
Hide resolved
Submitted by: Giovanni van der Schelde The integration test for the folder structure was flaky due to Files.list() returning the items in no particular order.
mthmulders
reviewed
Sep 8, 2021
src/test/java/org/apache/maven/plugins/gpg/it/GpgSignArtifactIT.java
Outdated
Show resolved
Hide resolved
Submitted by: Giovanni van der Schelde - Format the test file - Decrease the length of the test data to increase readability
mthmulders
approved these changes
Sep 29, 2021
|
Failed because branch name is too long; renamed branch to something shorter and trying again. |
|
Resolve #215 |
1 similar comment
|
Resolve #215 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The command
mvn verify assembly:single gpg:signcreates signed artifacts. It places the signed artifact alongside the original as long as the original artifact is stored in the project build directory.However, if the original artifact is not stored in the project build directory, and depending on the
ascDirectory(aliasoutputDirectory) in the pom configuration of the GPG plugin, this results in unexpected behaviour. For example, setting theascDirectorytotarget/tarballresults in the following directory structure/path/to/project/target/gpg/target/tarball/.This PR resolves the issue by checking whether the root directory - relative to the artifact - has been found and mostly adds integration tests to document this behaviour.
Following this checklist to help us incorporate your
contribution quickly and easily:
for the change (usually before you start working on it). Trivial changes like typos do not
require a JIRA issue. Your pull request should address just this issue, without
pulling in other changes.
[MGPG-XXX] - Fixes bug in ApproximateQuantiles,where you replace
MGPG-XXXwith the appropriate JIRA issue. Best practiceis to use the JIRA issue title in the pull request title and in the first line of the
commit message.
mvn clean verifyto make sure basic checks pass. A more thorough check willbe performed on your pull request automatically.
mvn -Prun-its clean verify).If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004
In any other case, please file an Apache Individual Contributor License Agreement.