[MJAR-279] maven-jar-plugin after upgrade of Maven to 3.8.3 doesn't include classpath to MANIFEST

[jira-importer]

Jakub Moravec opened MJAR-279 and commented

Plugin configuration:

<plugin>
  <groupId>org.apache.maven.plugins</groupId>
  <artifactId>maven-jar-plugin</artifactId>
  <configuration>
    <archive>
      <index>false</index>
      <manifest>
        <addClasspath>true</addClasspath>
        <useUniqueVersions>false</useUniqueVersions>
        <mainClass>eu.profinit.manta.platform.cli.Main</mainClass>
        <addDefaultImplementationEntries>true</addDefaultImplementationEntries>
        <addDefaultSpecificationEntries>true</addDefaultSpecificationEntries>
      </manifest>
    </archive>
  </configuration>
</plugin>

Diff of MANIFEST.MF before (mvn clean install executed with Maven 3.5.4) and after (mvn clean install executed with Maven 3.8.3) is attached. 

 

 

---

Affects: 3.2.0

Attachments:

• debug_3_5_4_OK.log (821.71 kB)
• debug_3_6_3_OK.log (821.14 kB)
• debug_3_8_1_OK.log (821.26 kB)
• debug_3_8_2_OK.log (816.10 kB)
• debug_3_8_3_NOK.log (810.17 kB)
• image-20211025-122928.png (35.86 kB)

[jira-importer]

Michael Osipov commented

Please provide -X output.

[jira-importer]

Michael Osipov commented

Please try 3.6.3, 3.8.1, 3.8.2 as well.

[jira-importer]

Jakub Moravec commented

Hi Michael Osipov, thanks for looking into this. Please find the debug logs attached. 3.8.3 is the only version that doesn't work. 

 

[jira-importer]

Michael Osipov commented

Thanks, I will look into it.

[jira-importer]

Michael Osipov commented

This is, though, somewhat confusing since the plugin does not change. Maybe a regression between 3.8.2 and 3.8.3. Are you maybe able to build Maven from master-3.8.x branch and retry? There is a current revert on that branch which Amy already solve your issue.

[jira-importer]

Michael Osipov commented

The logfile says you are still on: --- maven-jar-plugin:2.4:jar (default-jar) @ manta-platform-cli ---
Can you upgrade to 3.2.0 and see whether there is a change?

[jira-importer]

Greg A commented

Same issue experienced here. Happens only for maven 3.8.3 when jar plugin version is 2.4

Fixed by upgrading to jar plugin 3.2.0 or 3.1.2

[jira-importer]

Michael Osipov commented

Last Published: 2012-01-26 | Version: 2.4. Not going to investigate this old version. Jakub Moravec, waiting for your upgrade tests.

[jira-importer]

Jakub Moravec commented

Michael Osipov I can confirm it works with both versions. Thank you very much for your help!