Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 3 additions & 6 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
<parent>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-plugins</artifactId>
<version>45</version>
<version>48</version>
<relativePath />
</parent>

Expand Down Expand Up @@ -61,12 +61,9 @@
</distributionManagement>

<properties>
<mavenVersion>3.9.12</mavenVersion>
<mavenVersion>3.9.16</mavenVersion>
<javaVersion>8</javaVersion>
<project.build.outputTimestamp>2025-12-22T00:54:55Z</project.build.outputTimestamp>

<version.palantirJavaFormat>2.82.0</version.palantirJavaFormat>
<version.maven-invoker-plugin>3.9.1</version.maven-invoker-plugin>
</properties>

<dependencies>
Expand Down Expand Up @@ -150,7 +147,7 @@
<configuration>
<rules>
<enforceBytecodeVersion>
<maxJdkVersion>${maven.compiler.target}</maxJdkVersion>
<maxJdkVersion>${javaVersion}</maxJdkVersion>
<excludes>
<exclude>org.ow2.asm:asm</exclude>
</excludes>
Expand Down
2 changes: 1 addition & 1 deletion src/it/base-config-cmds/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/base-config-headerfiles/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/base-config-legalnotices/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/base-config-libs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/base-config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/base-it/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/describe-base-config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/describe-plain/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/list-base-config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/list-plain/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
10 changes: 10 additions & 0 deletions src/it/mjmod-20-set-main-class/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -49,11 +49,21 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<!-- When this version is not set to 3.8.0, but to @version.maven-compiler-plugin@ then jar-plugin 4.0.0-beta gets pulled in which is not defined anywhere, but is the latest in my local repository.
4.0.0-beta ofc is not compatible with Maven 3.9.x.
if you then set the jar-plugin to @version.maven-jar-plugin@, the java module (of the module-info) gets not found -->

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you are writing about jar-plugin but it is for compiler ...?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes changing the compiler version to @version.maven-compiler-plugin@ pulls in a 4.0.0-beta-1 jar-plugin version.

[DEBUG] org.apache.maven.plugins:maven-jar-plugin/maven-metadata.xml was not found in file:///C:/Users/matth/.m2/repository during a previous attempt. This failure was cached in the local repository and resolution is not be reattempted until the update interval of local.central has elapsed or updates are forced
[DEBUG] Skipped remote request for org.apache.maven.plugins:maven-jar-plugin/maven-metadata.xml, locally cached metadata up-to-date
[WARNING] Ignoring incompatible plugin version 4.0.0-beta-1
org.apache.maven.plugin.PluginIncompatibleException: 
The plugin org.apache.maven.plugins:maven-jar-plugin:4.0.0-beta-1 has unmet prerequisites: 
	Required Maven version 4.0.0-beta-3 is not met by current version 3.9.16

And yes this absolute does not makes sense, but I tried it multiple times.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤔

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@desruisseaux Do you maybe have an idea why the module-info might not be found, when I set @version.maven-jar-plugin@ (I'm not that into the module system by heart)

<version>3.8.0</version>
<configuration>
<release>9</release>
</configuration>
</plugin>
<!--
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-jar-plugin</artifactId>
<version>@version.maven-jar-plugin@</version>
</plugin>
-->
</plugins>
</pluginManagement>
<plugins>
Expand Down
2 changes: 1 addition & 1 deletion src/it/mjmod-23-path-must-be-dir/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<release>9</release>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion src/it/mjmod-8-generate-jmod-in-other-project/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.8.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<release>9</release>
</configuration>
Expand Down
2 changes: 1 addition & 1 deletion src/it/non-default-config-cmds/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/non-default-config-headerfiles/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/non-default-config-legalnotices/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/non-default-config-libs/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
2 changes: 1 addition & 1 deletion src/it/non-default-config/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-compiler-plugin</artifactId>
<version>3.7.0</version>
<version>@version.maven-compiler-plugin@</version>
<configuration>
<target>1.9</target>
<source>1.9</source>
Expand Down
Loading