-
Notifications
You must be signed in to change notification settings - Fork 12
[MPDF-8] Create one PDF from a multi module project #1
Conversation
|
Hi Anthony, Thanks for this great contribution: it works like a charm. But there is one serious issue before I can merge: org.json dependency can't be used, since its license is not free (a little addition to MIT license that cause many headache to many lawyers) please replace this dependency with another: Json format is not an issue, just this library A little enhancement for future work could also be to add a separator page for each module, since currently the swithc from one module to the next one is not really visible: but that one is not a blocker thanks again for your help: it is greatly appreciated |
|
Hi Hervé, Thanks for the comment and the PR. I will merge it right away. |
|
I switched to JSONUtil. Its license is Apache's 2004. Does it fit? |
|
everything should be fine now, I'll review in a few days |
|
ok, I worked quite a lot on this PR: I'll send you the result as a PR to your branch |
|
forget about my last explanations about MPDF-48: I'm completely wrong... |
|
if you agree with the changes, please squash the commits and update the PR: this time, I think it'll be ok to merge |
* fixed typo * formatting cleanup * [MPDF-88] upgraded Doxia Sitetools to 1.8.1 * [MNGSITE-328] use sha1 checksum instead of md5 * [MPDF-8] Create one PDF from a multi module project * fixed issues reported by Checkstyle * [MPDF-8] added IT * [MPDF-8] Switch to JSONUtil library (Apache license) * [MPDF-8] renamed stage to aggregate since aggregating goal * [MPDF-8] extracted TOC save/load code to TocFileHelper * [MPDF-8] separated aggregate from root module outputs
|
Thanks, Hervé! Commits squashed. |
|
merged in b03faf6 |
An attempt to fix MPDF-8.
It makes
maven-pdf-pluginlook a bit more likemaven-site-pluginin that it adds apdf:stagegoal which aggregates the intermediate outputs ofpdf:pdfof each sub-module.It is a working solution (at least in another project I work on) but nothing is perfect. TOC numbering seems wrong in final PDF (maybe not using a recent doxia with closed DOXIA-564; dependency issue on my part?).
I used JSON to serialize/deserialize the TOC of each sub-module but I can only start to guess it isn't standard maven way.
Comments are welcome.