-
Notifications
You must be signed in to change notification settings - Fork 68
Use Java 7 APIs and language features #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
eolivelli
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall okay.
But I think we should not add that plugin here, let's see opinions from the community
|
I think of #17 as separate since it is language vs. APIs but I can combine them if you prefer. |
|
@gaul We made the same changes in Surefire due to the changes in API are introduced in J7. So yes, the J7 has something new in language and API too but it is acceptable by Java compiler. |
|
Done. |
Found via error-prone and Modernizer.
|
Addressed all outstanding suggestions. |
|
LGTM |
|
Jira ticket created https://issues.apache.org/jira/browse/MPLUGIN-354 |
|
I created MPLUGIN-353 earlier. |
|
@gaul |
|
@gaul |
|
@gaul |
|
closing as merged |
Found via error-prone and Modernizer.