Skip to content

Conversation

@gaul
Copy link
Member

@gaul gaul commented Aug 31, 2019

Found via error-prone and Modernizer.

Copy link

@eolivelli eolivelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall okay.
But I think we should not add that plugin here, let's see opinions from the community

@Tibor17
Copy link

Tibor17 commented Aug 31, 2019

@gaul
You don't want to add the commit from #17 ?
I think it's all the Java 7 stuff.

@gaul
Copy link
Member Author

gaul commented Aug 31, 2019

I think of #17 as separate since it is language vs. APIs but I can combine them if you prefer.

@gaul gaul changed the title Add Modernizer and take advantage of Java 7 APIs Take advantage of Java 7 APIs Aug 31, 2019
@Tibor17
Copy link

Tibor17 commented Aug 31, 2019

@gaul We made the same changes in Surefire due to the changes in API are introduced in J7. So yes, the J7 has something new in language and API too but it is acceptable by Java compiler.

@gaul gaul changed the title Take advantage of Java 7 APIs Use Java 7 APIs and language features Sep 1, 2019
@gaul
Copy link
Member Author

gaul commented Sep 1, 2019

Done.

Found via error-prone and Modernizer.
@gaul
Copy link
Member Author

gaul commented Sep 11, 2019

Addressed all outstanding suggestions.

@Tibor17
Copy link

Tibor17 commented Sep 11, 2019

LGTM
This work is worth a Jira ticket.
@gaul
You will find the Jira URL in the POM. Pls login there and publish a new ticket with the same name of this PR. Then it would be a complete work.
Thx, and it's a good job in real!

@Tibor17 Tibor17 requested a review from eolivelli October 1, 2019 23:33
@Tibor17
Copy link

Tibor17 commented Oct 1, 2019

Jira ticket created https://issues.apache.org/jira/browse/MPLUGIN-354
Let's check this fix on Jenkins tomorrow.

@gaul
Copy link
Member Author

gaul commented Oct 1, 2019

I created MPLUGIN-353 earlier.

@Tibor17
Copy link

Tibor17 commented Oct 1, 2019

@gaul
ok, i will delete mine. Can you rewrite the commit message to:
[MPLUGIN-353] Use Java 7 APIs and language features
Thx

@Tibor17
Copy link

Tibor17 commented Oct 2, 2019

@Tibor17 Tibor17 self-assigned this Oct 2, 2019
@Tibor17
Copy link

Tibor17 commented Oct 2, 2019

@gaul
I am going to push this PR to master. If you want us to cut a new release version 3.6.1 force us on the mailing list for developer. Meanwhile we will wait for new fixes.

@Tibor17
Copy link

Tibor17 commented Oct 2, 2019

closing as merged

@Tibor17 Tibor17 closed this Oct 2, 2019
@gaul gaul deleted the modernizer branch October 2, 2019 17:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants