[MRESOLVER-588] Incomplete system properties in SessionBuilderSupplier

[jira-importer]

Hannes Wellmann opened MRESOLVER-588 and commented

The SessionBuilderSupplier provided for Maven3 sets the java System.properties as systemProperties of the Session to be build.

maven-resolver/maven-resolver-supplier-mvn3/src/main/java/org/eclipse/aether/supplier/SessionBuilderSupplier.java

Line 72 in d13019c

session.setSystemProperties(System.getProperties());

But it does not add environment variables with their key prefixed with env. like it is for example done in Maven or MIMA:

https://github.com/maveniverse/mima/blob/e851dee08706024929f1004e18e3dbd7b3522b36/runtime/standalone-shared/src/main/java/eu/maveniverse/maven/mima/runtime/shared/StandaloneRuntimeSupport.java#L519-L530

 

From looking at the code of the SessionBuilderSupplier for Maven 4, which relys heavily on org.apache.maven.repository.internal.MavenSessionBuilderSupplier system properties are not set at all.

My suggestion is to extend the Maven3 SessionBuilderSupplier in Maven-Resolver and in maven4 MavenSessionBuilderSupplier to have system-properties and environment variables fully set by default.

---

Affects: 2.0.0

Remote Links:

• GitHub Pull Request #539
  
• GitHub Pull Request #724
  

[jira-importer]

Tamas Cservenak commented

Changed my mind. 

Will do alt PR for both existing suppliers.