Bugfix: Java 25 broke test #1657
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As test was naively using `new File("")` assuming its
method `file.list()` will return `null` on cleanup
in `teardown()` method.
But, it turns out it was an old Java bug fixed in
Java 25, and once GH matrix got Java 25 introduced,
it broke the build.
Refs:
* https://bugs.openjdk.org/browse/JDK-8024695
* https://inside.java/2025/11/03/quality-heads-up/
Thanks to @sormuras
|
@cstamas Please assign appropriate label to PR according to the type of change. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As test was naively using
new File("")assuming its methodfile.list()will returnnullon cleanup inteardown()method.But, it turns out it was an old Java bug fixed in
Java 25, and once GH matrix got Java 25 introduced, it broke the build.
Refs:
Thanks to @sormuras