Feat: Expose scope related bits via scope manager#1862
Merged
Conversation
When Resolver 2.x is used with ScopeManager, the scope semantics cannot be taken for granted as it was in Maven 3.9 and before, as in this case scope manager configuration is the one who defines them, and their semantics as well. Hence, any scope related operation, like filtering and selecting (during collection) must be done in with scope manager prepared filter or selector.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When Resolver 2.x is used with
ScopeManager, the scope semantics cannot be taken for granted as it was in Maven 3.9 and before, as in this case, scope manager configuration is the one who defines them, and their semantics as well.Hence, any scope related operation, like filtering and selecting (during collection) must be done in with scope manager prepared filter or selector.
This PR fixes an issue never addressed in Resolver 2.x so far: it deprecated all the old "utils" that had wired-in scope semantics from Maven 3.9 and before times, but did not provide functionally equivalent replacement.