[MRESOLVER-361] Unreliable TCP and retries #288
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make httpClient retry for PUT. --- https://issues.apache.org/jira/browse/MRESOLVER-361
|
Should this retry handler respect |
Member
Author
This pr changes ONLY the fact that now client follows rfc2616 and treats listed methods (put among them) as idempotent. |
Member
Author
|
Latest commit exposes all aspects of retryHandler to users via config (defaults to "standard" handler as before in this PR) |
|
Under what circumstances would a user want the standard retry handler? |
Member
Author
|
No idea, but presence of these options allows to make resolver work "as before". Just an escape hatch, nothing more. |
|
Resolve #1037 |
1 similar comment
|
Resolve #1037 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make httpClient retry for PUT.
https://issues.apache.org/jira/browse/MRESOLVER-361