Skip to content

Update ASM to latest version#1

Closed
raphw wants to merge 1 commit intoapache:masterfrom
raphw:master
Closed

Update ASM to latest version#1
raphw wants to merge 1 commit intoapache:masterfrom
raphw:master

Conversation

@raphw
Copy link
Contributor

@raphw raphw commented Apr 1, 2018

Update to ASM 6.1.1

Update to ASM 6.1.1
@struberg
Copy link
Member

struberg commented Apr 1, 2018

is probably related to MSHADE-275

@khmarbaise
Copy link
Member

khmarbaise commented Apr 1, 2018

Exactly it is...The problem is at the moment that org.vafer:jdependency contains an older version of ASM shaded in the jar which means at the moment that we can't overwrite the dependency nor replace it simple...also excluding does not help here...See tcurdt/jdependency#13....

@raphw
Copy link
Contributor Author

raphw commented Apr 1, 2018

I did not know that but I just overruled the dependencies in my build within the tag and I can now successfully build on Java 10. I had to do the same for the maven-plugin-plugin.

@khmarbaise
Copy link
Member

Have you run the IT's ?

@raphw
Copy link
Contributor Author

raphw commented Apr 2, 2018

No, I meant that I can build my project on Java 10 that uses the Maven Shade plugin which did not build because of the outdated ASM version before.

@khmarbaise
Copy link
Member

Ah very good. Misunderstanding on my site...that's good to know that it helps that way...Do you have a chance to test a SNAPSHOT version? I can offer one ....

@raphw
Copy link
Contributor Author

raphw commented Apr 2, 2018

Absolutely. It should even work if you fork the repository https://github.com/raphw/byte-buddy as CI picks up all branches.

@khmarbaise
Copy link
Member

khmarbaise commented Apr 2, 2018

@raphw
Copy link
Contributor Author

raphw commented Apr 2, 2018

The snapshot works fine with my build.

@khmarbaise
Copy link
Member

Great. So I can continue to make a new release of maven-shade-plugin. Thanks for your feedback.

@khmarbaise
Copy link
Member

VOTE for new release of maven-shade-plugin 3.1.1 https://www.mail-archive.com/dev@maven.apache.org/msg116597.html has started.

@khmarbaise khmarbaise closed this Apr 2, 2018
@jira-importer
Copy link

Resolve #471

1 similar comment
@jira-importer
Copy link

Resolve #471

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants