Xpp3Dom.getValue(): honor @NonNull contract#389
Merged
Conversation
sparsick
approved these changes
Jul 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Xpp3Dom.getValue()is annotated@NonNull(line 141) but can returnnullwhen the instance was created vianew Xpp3Dom(name)(thevaluefield is never initialized in the one-arg constructor).Fix:
getValue()now returns""when the internalvaluefield is null, upholding the@NonNullcontractisValueSet()method soXpp3DomWritercan distinguish between "value was explicitly set to empty string" and "value was never set" — preserving the existing serialization behavior (elements with unset values serialize as self-closing tags)The builder at
Xpp3DomBuilder.java:201already worked around this withelement.setValue(""); // null in xpp3dom, but we don't do that around here.Fixes #388