Skip to content

[MSHARED-993] Make uninstall resilient to Jansi errors#93

Closed
guylabs wants to merge 2 commits intoapache:masterfrom
guylabs:MSHARED-993
Closed

[MSHARED-993] Make uninstall resilient to Jansi errors#93
guylabs wants to merge 2 commits intoapache:masterfrom
guylabs:MSHARED-993

Conversation

@guylabs
Copy link

@guylabs guylabs commented Jul 7, 2021

See https://issues.apache.org/jira/browse/MSHARED-993 for details.

There is no unit/integration test for this as it would require to use Powermock or similar to mock Jansi. If requested, I can add this but I thought that this would be an overkill.

@elharo elharo changed the title Make uninstall resilient to Jansi errors [MSHARED-993] Make uninstall resilient to Jansi errors Jul 13, 2021
elharo
elharo previously requested changes Jul 13, 2021
Copy link
Contributor

@rfscholte rfscholte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We're still trying to fix this at JAnsi. This should only be accepted if JAnsi explcitly states they won't fix it.

@guylabs
Copy link
Author

guylabs commented Jul 13, 2021

We're still trying to fix this at JAnsi. This should only be accepted if JAnsi explcitly states they won't fix it.

There are still no reactions to fusesource/jansi#214. Not sure what the timeline is for the proper fix. Do you maybe have any other insights @rfscholte ?

@elharo elharo dismissed their stale review July 13, 2021 23:06

done

@rfscholte
Copy link
Contributor

We're still trying to fix this at JAnsi. This should only be accepted if JAnsi explcitly states they won't fix it.

There are still no reactions to fusesource/jansi#214. Not sure what the timeline is for the proper fix. Do you maybe have any other insights @rfscholte ?

We're working on it as we have more ways to get direct contact with the maintainer(s). But I agree, it takes more time, must be the summer ;)

@guylabs
Copy link
Author

guylabs commented Jul 25, 2021

@rfscholte Ok to close this pull request as fusesource/jansi#214 has been fixed now ? Should we then also close https://issues.apache.org/jira/browse/MSHARED-993 ?

@rfscholte
Copy link
Contributor

Yes, I'll close them both.

@rfscholte rfscholte closed this Jul 25, 2021
@guylabs guylabs deleted the MSHARED-993 branch July 25, 2021 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants