[MSHARED-993] Make uninstall resilient to Jansi errors#93
[MSHARED-993] Make uninstall resilient to Jansi errors#93guylabs wants to merge 2 commits intoapache:masterfrom
Conversation
src/main/java/org/apache/maven/shared/utils/logging/MessageUtils.java
Outdated
Show resolved
Hide resolved
rfscholte
left a comment
There was a problem hiding this comment.
We're still trying to fix this at JAnsi. This should only be accepted if JAnsi explcitly states they won't fix it.
There are still no reactions to fusesource/jansi#214. Not sure what the timeline is for the proper fix. Do you maybe have any other insights @rfscholte ? |
We're working on it as we have more ways to get direct contact with the maintainer(s). But I agree, it takes more time, must be the summer ;) |
|
@rfscholte Ok to close this pull request as fusesource/jansi#214 has been fixed now ? Should we then also close https://issues.apache.org/jira/browse/MSHARED-993 ? |
|
Yes, I'll close them both. |
See https://issues.apache.org/jira/browse/MSHARED-993 for details.
There is no unit/integration test for this as it would require to use Powermock or similar to mock Jansi. If requested, I can add this but I thought that this would be an overkill.