[SUREFIRE-839] Tests not matching categories would fail build

[agudian]

Fixed in a way that does not break forkMode=onceperthread (enhanced the IT for that), refined the logic of JUnitCoreProvider.canRunClass (to also detect the BasicTest class from the IT)

[Tibor17]

This is behaviour of JUnit Categories.

Instead of patching surefire, thinking the JUnit would report an issue and get an answer.

If this behavior is intended in JUnit, then this is right solution.

[krosenvold]

@Tibor17 I'm unsure about this; it seems like the category parsing inside junit is slightly broken:

If you send a single class to junit core and that has no matches on the categories it fails miserably. Does that seem right to you ?

[agudian]

Oops, seems like I have broken six other ITs with this commit... I close it now and check what went wrong there...

[Tibor17]

@krosenvold
No it's not right according to me.

I think, the right appoach would be to ask the author in Junit, if this corner behavior was intended.
The reason is that too much code is place for mistakes and bugs. It looks like 2.12.x versions were such case.

Any way, this behaiour is not mentioned in JUnit documentation.

There are other such corner behaviors, the only thing is to get voters.

[Tibor17]

@krosenvold
Sorry for my question, but there is no forum page.

I would like to make a progress about Parallel Computer, but I have problems with pushing a new pull.

Every time I try to push a new branch the github gives it up, even the checkout fails.
Should I push to other repository, and not here? If yes, how to get the rights there?

Thx a lot.

[krosenvold]

Normally, you would clone the apache github repo to your own account and push to there; subsequently send a pull request.

You can send me an email at krosenvold at apache.org if there's something to help. Out mailing list is dev@maven.apache.org.