Consistently rename JUnit 4.x integration tests#125
Merged
asfgit merged 1 commit intoapache:masterfrom Oct 12, 2016
Merged
Conversation
Tibor17
reviewed
Oct 4, 2016
| @@ -32,14 +32,14 @@ | |||
| * | |||
| * @author Kristian Rosenvold | |||
| */ | |||
| public class Junit47concurrencyIT | |||
Contributor
There was a problem hiding this comment.
Why changing these names is important? Are you sure you have changed all occurencies of folder concurrentjunit47?
Member
Author
There was a problem hiding this comment.
Because consistency is a good thing :-) There are some tests named "JunitXXX" and some "JUnitXXX". It's better to have only one naming convention.
Yes I've searched the whole project for occurrences of "concurrentjunit47".
Contributor
There was a problem hiding this comment.
@britter I like the change :) and I appreciate it but the problem is with me last week I was unable to work in ASF.
Contributor
|
@britter |
britter
force-pushed
the
naming-conventions
branch
from
7d0ef33 to
77cafbe
Compare
Member
Author
|
@Tibor17 rebased with master. |
Contributor
|
@britter |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.