Skip to content

Surefire 1695 - implement reviewer comments#254

Closed
YiannisDermitzakis wants to merge 3 commits into
apache:masterfrom
YiannisDermitzakis:SUREFIRE-1695
Closed

Surefire 1695 - implement reviewer comments#254
YiannisDermitzakis wants to merge 3 commits into
apache:masterfrom
YiannisDermitzakis:SUREFIRE-1695

Conversation

@YiannisDermitzakis
Copy link
Copy Markdown

No description provided.

- Only traverse superclasses if @category annotation is inherited
- clean up & format code
- add/improve IT tests
@Tibor17
Copy link
Copy Markdown
Contributor

Tibor17 commented Nov 13, 2019

@IoannisDermitzakis
@YiannisDermitzakis
You have old starting point commit? We have applied the checkstyle to tests as well.
But notice that the code style config in IDEA/Eclipse badly adjusted the text.
It is sometimes worse to read the code if you automatically adjust.
It's fine when we satisfy the Maven checkstyle but the one in IDEA needs to be improved.

@YiannisDermitzakis
Copy link
Copy Markdown
Author

yes I noticed.. I used IntelliJ but the formatter does not work correctly. I'll try with Eclipse and resubmit (on the original PR)

@Tibor17
Copy link
Copy Markdown
Contributor

Tibor17 commented Nov 20, 2019

@YiannisDermitzakis
ok, feel free to ping me with new PR. Thx

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants