Skip to content

[WAGON-469] wagon-http does not enable Expect-Continue by default#31

Closed
mcculls wants to merge 1 commit intoapache:masterfrom
mcculls:WAGON-469-enable-expect-continue-by-default
Closed

[WAGON-469] wagon-http does not enable Expect-Continue by default#31
mcculls wants to merge 1 commit intoapache:masterfrom
mcculls:WAGON-469-enable-expect-continue-by-default

Conversation

@mcculls
Copy link
Contributor

@mcculls mcculls commented Dec 9, 2016

There appear to be two issues:

  • Expect-Continue is not enabled for PUT when no configuration is provided
  • The default Expect-Continue configuration parameter uses the wrong key

@michael-o
Copy link
Member

Looks very good. Please squash and I will merge it.

* enable Expect-Continue for PUTs when no configuration is provided
* use correct key for default Expect-Continue configuration parameter

(HTTP.EXPECT_CONTINUE constant is the expectation name, not the parameter key)
@mcculls mcculls force-pushed the WAGON-469-enable-expect-continue-by-default branch from 6aab1bd to a6ecd8d Compare December 10, 2016 00:25
@mcculls
Copy link
Contributor Author

mcculls commented Dec 10, 2016

OK, squashed

@asfgit asfgit closed this in 5d60026 Dec 10, 2016
@jira-importer
Copy link

Resolve #525

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants