Skip to content

Remove unused class #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
pzygielo wants to merge 3 commits into from
Closed

Remove unused class #69

pzygielo wants to merge 3 commits into from

Conversation

@pzygielo
Copy link
Contributor

@pzygielo pzygielo commented Jun 7, 2020

No description provided.

@pzygielo
Copy link
Contributor Author

pzygielo commented Jun 20, 2020

May I ask for review, please?

@michael-o
Copy link
Member

michael-o commented Jun 20, 2020

Looking into...

@michael-o
Copy link
Member

michael-o commented Jun 20, 2020

I wonder why the class is there, but never used...

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 6, 2020

Ping.

@michael-o
Copy link
Member

michael-o commented Jul 6, 2020

Need to understand first why the class is redundant.

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 19, 2020

@olamy - could you shed some light on WAGON-350 related changes, please?
For me it looks like code removed in this PR is unused in both commits e248eee and in next 1f6719c (and currently unused too).
(WAGON-350 was closed without fixing, yet plenty of commits refer to it. 😕)

@pzygielo
Copy link
Contributor Author

pzygielo commented Jul 27, 2020

Ping.

@pzygielo pzygielo closed this Aug 3, 2020
@pzygielo pzygielo deleted the unused_pf branch August 3, 2020 07:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@pzygielo @michael-o