Skip to content

Fix #590 : Check mkdirs() result during WAR assembly#618

Open
HarshMehta112 wants to merge 3 commits into
apache:masterfrom
HarshMehta112:fix/#590
Open

Fix #590 : Check mkdirs() result during WAR assembly#618
HarshMehta112 wants to merge 3 commits into
apache:masterfrom
HarshMehta112:fix/#590

Conversation

@HarshMehta112

Copy link
Copy Markdown

Fixes : #590

This change adds proper validation for directory creation by checking the return value of mkdirs() and throwing a MojoExecutionException if the directory cannot be created.

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the integration tests successfully (mvn -Prun-its verify).

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

* @return the temp directory for the overlay
*/
protected File getOverlayTempDirectory(WarPackagingContext context, Overlay overlay) {
protected File getOverlayTempDirectory(WarPackagingContext context, Overlay overlay) throws MojoExecutionException {

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is tricky because we don't want to change the signature here. maybe remove this file from the pR and come back to it in another PR

@elharo elharo closed this Jul 4, 2026
@elharo elharo reopened this Jul 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

mkdirs return value is ignored

2 participants