[MWAR-430] Discover Jakarta Servlet API as excuse for not having web.xml

[pzygielo]

@olamy may I ask for review, please?

[khmarbaise]

It would be great if you could squash the commits into a single one. Apart from that looks fine for me. When you have squashed we can check on ASF CI ...

[khmarbaise]

@olamy WDYT?

[pzygielo]

@khmarbaise - commits squashed

[pzygielo]

1. so it seems that (failed) 🔴 build 1 ran against 4 commits (it should not matter as contents is the same)
2. I executed verify -P run-its (before push) locally on linux/jdk8 and as on Jenkins - it's ok in my env
3. on first read of 1/consoleFull failure is not obvious for me.
   I suspected that new class from jakarta

$ file WebServlet.class 
WebServlet.class: compiled Java class data, version 52.0 (Java 1.8)

could not collaborate with JDK7.:

Caused by: java.lang.UnsupportedClassVersionError: jakarta/servlet/annotation/WebServlet : Unsupported major.minor version 52.0
...
    at org.apache.maven.plugins.war.WarMojo.hasClassInClasspath (WarMojo.java:341)

but a lot more ITs fail with JDK7, not new one only, so I'm a bit confused...

---

^{Some ITs fail locally due to no other reason but}

Caused by: javax.net.ssl.SSLException: Received fatal alert: protocol_version

^{for artifacts that are missing in my repository, and maven on JDK7 can't establish connection with central. Setting -Dhttps.protocols=TLSv1.2 doesn't help, but getting dependency/plugin in other way into repository - does.}

[pzygielo]

In blue ocean/pipeline view it's clear that JDK7 is common factor.

[hboutemy]

if the new IT requires Java 8, you can mark it with invoker.properties
see for example https://github.com/apache/maven-pmd-plugin/blob/master/src/it/MPMD-302-JDK14/invoker.properties

[pzygielo]

if the new IT requires Java 8, you can mark it with invoker.properties
see for example https://github.com/apache/maven-pmd-plugin/blob/master/src/it/MPMD-302-JDK14/invoker.properties

Thanks, that's what I did in #9.

[pzygielo]

@hboutemy - but with your confirmation that it's the way to go I'll squash #9 here and push new commit for review.

[hboutemy]

IMHO, no need for UnsupportedClassVersionError check: this won't happen for end-users
limiting the execution of the IT to 8+ JDK versions is sufficient

[pzygielo]

IMHO, no need for UnsupportedClassVersionError check: this won't happen for end-users
limiting the execution of the IT to 8+ JDK versions is sufficient.

Just to clarify my understanding: if there is jakarta's web servlet annotation in CP (only then plugin would load this class), it means also that project is already compiled with JDK8+. Right? In such case, catching UCVE isn't needed indeed!

[olamy]

LGTM! Thanks for fixing this.

[jira-importer]

Resolve #495

[jira-importer]

Resolve #495