Skip to content

Conversation

@slawekjaranowski
Copy link
Member

  • fix detecting Maven distribution in script
  • fix in IT - use time based snapshot in mock repo
  • check in IT proper result code of Maven executable
  • set distributionUrl in setup invoker task, as test.properties is not filtered

@slawekjaranowski
Copy link
Member Author

- fix detecting Maven distribution in script
- fix in IT - use time based snapshot in mock repo
- check in IT proper result code of Maven executable
- set distributionUrl in setup invoker task, as test.properties is not filtered
@slawekjaranowski
Copy link
Member Author

slawekjaranowski commented Aug 23, 2025

looks like shel globs not working ... in code

  for dir in "$TMP_DOWNLOAD_DIR"/*; do
    if [ -d "$dir" ]; then
      if [ -f "$dir/bin/$MVN_CMD" ]; then
        actualDistributionDir="$(basename "$dir")"
        break
      fi
    else
      verbose "Skipping non-directory file in $TMP_DOWNLOAD_DIR: $dir"
    fi
  done

on GH and on my local host we have:

Skipping non-directory file in /tmp/tmp.19TOqPxbAJ: /tmp/tmp.19TOqPxbAJ/*

but content is present:

Contents of /tmp/tmp.91g2xyJ6Db:
total 24
drwx------  3 runner docker  4096 Aug 23 11:26 .
drwxrwxrwt 16 root   root   12288 Aug 23 11:26 ..
-rw-r--r--  1 runner docker  1734 Jul 10 12:04 apache-maven-4.9.999-20250710.120440-1-bin.zip
drwxr-xr-x  3 runner docker  4096 Aug 23 11:25 apache-maven-4.9.999-SNAPSHOT

@gnodet or some other can help?

@slawekjaranowski
Copy link
Member Author

😄
we have disabled globbing at the scrip begin by:

set -euf

@slawekjaranowski slawekjaranowski self-assigned this Aug 23, 2025
@slawekjaranowski slawekjaranowski added the skip-changelog Skip this PR from automatically changelog generation label Aug 23, 2025
@slawekjaranowski
Copy link
Member Author

skip from change log as it is fix for existing item

@slawekjaranowski slawekjaranowski added the bug Something isn't working label Aug 23, 2025
@slawekjaranowski slawekjaranowski added this to the 3.3.3 milestone Aug 24, 2025
@slawekjaranowski slawekjaranowski merged commit 36886fa into apache:master Aug 26, 2025
21 checks passed
@slawekjaranowski slawekjaranowski deleted the fix-snap branch August 26, 2025 17:39
@github-actions github-actions bot removed this from the 3.3.3 milestone Aug 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working skip-changelog Skip this PR from automatically changelog generation

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant