WARNING: A restricted method in java.lang.System has been called (part 3?)

[gian1200]

Affected version

3.9.14

Bug description

Following #11289.

I'm getting the warning with Maven wrapper

• OS: Windows
• JDK: 25
• Wrapper: mvn wrapper:wrapper -Dtype=source

It only fails when using the wrapper.

Maven

> mvn -v            
Apache Maven 3.9.14 (996c630dbc656c76214ce58821dcc58be960875b)
Maven home: C:\Program Files\Maven\apache-maven-3.9.14
Java version: 25.0.2, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-25.0.2.10-hotspot
Default locale: en_US, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

Maven Wrapper

> ./mvnw -v         
WARNING: A restricted method in java.lang.System has been called
WARNING: java.lang.System::load has been called by org.fusesource.jansi.internal.JansiLoader in an unnamed module (file:/C:/Users/<redacted>/.m2/wrapper/dists/apache-maven-3.9.14-bin/5d54584a/apache-maven-3.9.14/lib/jansi-2.4.2.jar)
WARNING: Use --enable-native-access=ALL-UNNAMED to avoid a warning for callers in this module
WARNING: Restricted methods will be blocked in a future release unless native access is enabled

Apache Maven 3.9.14 (996c630dbc656c76214ce58821dcc58be960875b)
Maven home: C:\Users\<redacted>\.m2\wrapper\dists\apache-maven-3.9.14-bin\5d54584a\apache-maven-3.9.14
Java version: 25.0.2, vendor: Eclipse Adoptium, runtime: C:\Program Files\Eclipse Adoptium\jdk-25.0.2.10-hotspot
Default locale: en_US, platform encoding: UTF-8
OS name: "windows 11", version: "10.0", arch: "amd64", family: "windows"

[cstamas]

This is a wrapper issue? Fix in mvnw was
eeddfa2

[cstamas]

Question @gian1200
I see you use -Dtype=source, if I may ask why? The only-script is the default, and that fully delegates to mvn script that has this fix. Any particular reason to use non-default type?

[gian1200]

We have used it for quite a while, now.

• AFAIK, only-script depends on the maven version installed/configured on the host where the project is going to be executed, right? It doesn't control which maven version is already installed.
• source lets you download the specific version (useful when 3rd parties works with different/multiple maven versions).
• We don't use bin because having the binary versioned within the project feels unnecessary.

source feels like the sweet spot between flexibility and consistency.

---

By your comment, does it mean that the issue was not expected to be fixed for all distribution types?

[gian1200]

PS: the docs mention that bin is the default 🤔

https://maven.apache.org/tools/wrapper/maven-wrapper-distribution/

[cstamas]

Nope, only-script only "delegates" to mvn script, but also downloads whatever is in maven-wrapper.properties specified. Try it out. They all do pretty much same, but only-script was later donated by user, as he was also annoyed that mvn scripts (in distro) and mvnw scripts in wrapper were many times (like in this case) unsynced/different/lacked changes.

[cstamas]

PS: the docs mention that bin is the default 🤔

https://maven.apache.org/tools/wrapper/maven-wrapper-distribution/

Bug in doco 😄
This one says otherwise https://maven.apache.org/tools/wrapper/index.html

[gian1200]

I’ll test it, but the question remains: shouldn’t this be fixed for all distribution types, regardless of whether the default option or a user preference is used?

[cstamas]

Yes, it should, but the problem is not here (maven) but in https://github.com/apache/maven-wrapper/ project, as except for only-scrip, that "just delegates", all the other types reimplement (duplicate) mvn script. Basically those types must be kept in sync with distro mvn script, and is easy to miss porting changes.

[gian1200]

Woops, my bad. I searched for the maven wrapper repo and was redirected to this one (https://issues.apache.org/jira/browse/MNG-8248 was pointing to here); and because I also found similar issues here (#11289).

I'll create a new issue in the correct repo (if one was not already created).

Thanks! 👍🏻

[cstamas]

Yup, as fix was done in distro mvn script, here. But again, all other types of wrapper than only-script must have all changes duplicated.