[MNG-6296] New option -Dstyle.color is not working

[jira-importer]

Robin Müller opened MNG-6296 and commented

The new option -Dstyle.color=(auto|always|never) is not working. This happens as the corresponding code accesses the UserProperties of the CliRequest before they are set. I'll provide a quick fix for this by changing the order of the methods in the doMain method so the properties will be set at the right time.
But I'd suggest to refactor the whole stuff so the code will become easier to understand and maintain. IMHO the functionality of the properties method in the MavenCli should be moved to the constructor of the CliRequest. The CliRequest itself should be immutable so all fields will have the correct content all the time.

---

Affects: 3.5.2

Issue Links:

• MNG-5835 Maven-Plugin's getLog() ignores -Dorg.slf4j.simpleLogger.defaultLogLevel=warn
  ("incorporates")

• MNG-6380 Option -Dstyle.color=always doesn't force color output

• MNG-6241 colour output cannot be disabled from settings.xml or MAVEN_OPTS

• MNG-6220 Add CLI options to control color output
  ("breaks")

Remote Links:

• GitHub Pull Request #135
  
• GitHub Pull Request #135
  

4 votes, 14 watchers

[jira-importer]

Robert Scholte commented

Fix in b2afafe5a252d9f86b3e43cce8a06dc9cdc7a6d7
Thanks for the patch!

[jira-importer]

Henning Hoefer commented

Sorry, but this needs to be reopened, as it still doesn't work properly in Maven 3.5.3.

1. OK, produces color:
mvn -Dstyle.color=always package

1. OK, produces color:
mvn --batch-mode -Dstyle.color=always package

1. FAIL, doesn't produce color:
mvn -Dstyle.color=always package | less -r

The problem seems to be with the output redirection. The switch works for forcing color output even in batch mode, but it doesn't work when the output is not a TTY.

[jira-importer]

Robert Scholte commented

Henning Hoefer just create a new issue, because it is fixed based on the original description. This is an issue of a different kind of category.

[jira-importer]

Daniel Beland commented

Henning Hoefer have you tried by setting -Djansi.force=true in MAVEN_OPTS?

The problem is even if maven enables colors, the jansi library has its own logic to detect if the current terminal supports color. The property above will force jansi to output colors.

I had to do that in jenkins.

 

[jira-importer]

Henning Hoefer commented

Yes I tried that, and it is in fact a workaround – but -Dstyle.color=always should mean always so I did as Robert Scholte told me and opened MNG-6380 :)