[MNG-7133] Allow to inline collection/array items within plugin root configuration

[jira-importer]

Slawomir Jaranowski opened MNG-7133 and commented

Currently we can have plugin configurations like:

<configuration>
  <listParam>
    <listParam>Foo*</listParam>
    <listParam>Bar*</listParam>
  </listParam>
<configuration>

But when we have plugin configuration like:

<configuration>
  <listParam>Foo*</listParam>
  <listParam>Bar*</listParam>
<configuration>

and add method addListParam to Plugin mojo class this is not working.

addListParam method on plugin level is called only once

Plugin code:

public class MyMojo extends AbstractMojo {
    
    @Parameter
    private List<String> listParam;

    /**
    * special method called when inline collection in configuration is used.
    */
    public void addListParam(String value) {
        listParam.add(value);
    }
}

---

Affects: 3.6.3

Issue Links:

• MNGSITE-445 Document "inlined collections" approach for plugin configuration

• MNG-5033 Allow to inline collection/array items within plugin configuration

Remote Links:

• GitHub Pull Request #464
  

0 votes, 5 watchers

[jira-importer]

Michael Osipov commented

Use:

<includes>
  <include>...</include>
  ..
</includes>

[jira-importer]

Slawomir Jaranowski commented

Yes I know, that I must wrap collections in additional xml tag.

This issue is reported as improvement like MNG-5033 to have possibility configure collections without additional wrap element in xml.

Additionally looks like some of code is ready for it because addXxx method on plugin mojo is called but only once.

[jira-importer]

Michael Osipov commented

I wonder whether some Plexus components needs to be changed or MPLUGIN...

[jira-importer]

Slawomir Jaranowski commented

No dependency need to be changed.

[jira-importer]

Robert Scholte commented

What missing here is the context of the includes. Suppose there's also a

<directorySet>
  <includes/>
</directorySet>

How do I know that the includes at configuration-level is for fileSet and not directorySet?

[jira-importer]

Slawomir Jaranowski commented

ok, maybe example is not accurate, maybe some used name is misunderstood - I updated issue description.