[MNG-7496] DefaultArtifactDescriptorReader.loadPom() should query the MavenWorkspaceReader first

[jira-importer]

Christoph Läubrich opened MNG-7496 and commented

Now WorkspaceReaders work in extensions and while I develop a basic implementation in Tycho I noticed that I get asked for a pom, but not for the model first.

The reason is that DefaultArtifactDescriptorReader.loadPom() do not query the workspace reader but always resolves the pom artifact and then reads the pom file. But afterwards, it do query the maven reader and use the model there.

I don't know if there is an need to download the pom always (but not use it...), at least in my case it requires me to write the model to disk (with possibly incomplete content as I only get the pom artifact, but not the actual artifact the model is searched for) to make maven happy or I'll get nasty:

[WARNING] The POM for ... is missing, no dependency information available

My idea would be, to simply first as the WSR for the model and if it is present do not perform any actions or, at least ask the WSR first before fail and issue a warning...

---

Affects: 3.8.6

Issue Links:

• MNG-7591 Enhance MavenWorkspaceReader to find workspace projects

[jira-importer]

Michael Osipov commented

Interesting, why not...Do you have some code ready?

[jira-importer]

Christoph Läubrich commented

Not yet, just checked the source for now, first wanted to make sure I do not oversee something, but if you think its useful I can prepare a PR (for 3.9.x)