[master] Improve DefaultModelProcessor error reporting for alternative parsers (#11529) #11532
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…apache#11529) When multiple model parsers are registered (e.g., for YAML or TOML POMs) and all parsers fail to parse a POM file, the error message now provides detailed information about each parser's failure. Changes: - Changed modelParsers from List to Map<String, ModelParser> to preserve parser names for better error messages - Added buildDetailedErrorMessage() method that generates a comprehensive error report including: - The POM file path - The number of parsers attempted - Each parser's error with line/column information when available - The default XML reader's error - Updated all call sites to use Map.of() instead of List.of() This improves debugging when using alternative POM formats by showing exactly why each parser failed, rather than just the final XML error. (cherry picked from commit 71261c2) # Conflicts: # impl/maven-impl/src/test/java/org/apache/maven/impl/DefaultPluginXmlFactoryTest.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
maven-4.0.xtomaster:Questions ?
Please refer to the Backport tool documentation