[maven-4.0.x] Fix special characters in .mvn/jvm.config (fix #11363, #11485 and #11486) (#11365) #11537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…1485 and apache#11486) (apache#11365) Replace shell-based jvm.config parsing with a Java-based parser to fix issues with special characters (pipes, @, quotes) that cause shell command errors. Problems fixed: - MNG-11363: Pipe symbols (|) in jvm.config cause shell parsing errors - apacheGH-11485: @ character in paths (common in Jenkins workspaces like project_PR-350@2) causes sed failures - MNG-11486: POSIX compliance issues with xargs -0 on AIX, FreeBSD, etc. Solution: Add JvmConfigParser.java that runs via Java source-launch mode (JDK 11+) to parse jvm.config files. This avoids all shell parsing complexities and works consistently across Unix and Windows platforms. Changes: - Add apache-maven/bin/JvmConfigParser.java: Java parser that handles quoted arguments, comments, line continuations, and ${MAVEN_PROJECTBASEDIR} substitution - Update mvn (Unix): Use JvmConfigParser instead of tr/sed/xargs pipeline - Update mvn.cmd (Windows): Use JvmConfigParser with direct file output to avoid Windows file locking issues with shell redirection - Add MAVEN_DEBUG_SCRIPT environment variable for debug logging in both scripts to aid troubleshooting - Add integration tests for pipe symbols and @ character handling - Improve Verifier to save stdout/stderr to separate files for debugging The parser outputs arguments as quoted strings, preserving special characters that would otherwise be interpreted by the shell. (cherry picked from commit da5f27e) # Conflicts: # its/core-it-support/maven-it-helper/src/main/java/org/apache/maven/it/Verifier.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mastertomaven-4.0.x:Questions ?
Please refer to the Backport tool documentation