[MNG-7422] chore: Remove Juava reference#11787
Closed
andy-k-improving wants to merge 1 commit intoapache:masterfrom
Closed
[MNG-7422] chore: Remove Juava reference#11787andy-k-improving wants to merge 1 commit intoapache:masterfrom
andy-k-improving wants to merge 1 commit intoapache:masterfrom
Conversation
andy-k-improving
changed the title
Member
|
You did not remove guava, you just unmanaged it. As explained on issue, Guava is transitive dependency of Guice. |
Author
|
@cstamas Actually you are right, as long as Guice exist, Juava will continue to be around, closing this for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a PR to follow up on #9156 as the repo is not using Guava directly, Guice can continue to have it as transitive, but then there is no need to declare on parent POM.
Following this checklist to help us incorporate your
contribution quickly and easily:
Your pull request should address just one issue, without pulling in other changes.
Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
Each commit in the pull request should have a meaningful subject line and body.
Note that commits might be squashed by a maintainer on merge.
Run
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
I hereby declare this contribution to be licenced under the Apache License Version 2.0, January 2004