Fix @PreDestroy ClassNotFoundException from premature ClassRealm disposal#11825
Open
Fix @PreDestroy ClassNotFoundException from premature ClassRealm disposal#11825
Conversation
… ClassRealm disposal The Plexus Disposable.dispose() lifecycle runs before Sisu's @PreDestroy callbacks. When dispose() called flush(), it disposed ClassRealms before @PreDestroy methods on beans loaded from those realms could execute, causing ClassNotFoundException. Change dispose() to only clear the cache map without disposing realms. The flush() method (used for explicit cache clearing between builds) remains unchanged. ClassRealms are disposed when the PlexusContainer shuts down after all lifecycle callbacks complete. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DefaultExtensionRealmCache,DefaultPluginRealmCache, andDefaultProjectRealmCacheimplement PlexusDisposabledispose()method calledflush(), which disposed ClassRealms viarealm.getWorld().disposeRealm()Disposable.dispose()runs before Sisu's@PreDestroycallbacks, so beans loaded from extension/plugin ClassRealms would getClassNotFoundExceptionwhen their@PreDestroymethods executeddispose()now only clears the cache map without disposing realms. Theflush()method (for explicit cache clearing between builds) remains unchanged.Fixes #10571
Test plan
@PreDestroylifecycle methods no longer throwClassNotFoundExceptionat shutdownflush()still works correctly for cache clearing between builds (e.g., resident Maven)🤖 Generated with Claude Code