Fixes issue #11827 - Maven DI crashes if the file org.apache.maven.api.di.Inject contains empty lines#11830
Merged
slawekjaranowski merged 1 commit intoapache:maven-4.0.xfrom Mar 24, 2026
Conversation
…ven.api.di.Inject contains empty lines * Fixes issue apache#11827 * Use Java 17 features * Issue apache#11827 - Trim each read line to avoid related errors (cherry picked from commit 1867737)
gnodet
approved these changes
Mar 24, 2026
Contributor
gnodet
left a comment
There was a problem hiding this comment.
LGTM. Clean and correct fix.
The change properly handles empty lines and whitespace in META-INF/maven/org.apache.maven.api.di.Inject service files, which is a common scenario when using Shade plugin's AppendingTransformer to merge these files from multiple JARs.
The .map(String::trim).filter(l -> !l.isEmpty()) pattern follows the same convention as Java's ServiceLoader for parsing service provider configuration files.
Minor note: no unit test was added for discover(), but the fix is defensive and straightforward. A test could be added later if desired.
Claude Code on behalf of Guillaume Nodet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit 1867737)
Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.