Feat: Add id attribute (gav) support to Dependency, Exclusion, Mixin#11904
Open
rbygrave wants to merge 2 commits intoapache:masterfrom
Open
Feat: Add id attribute (gav) support to Dependency, Exclusion, Mixin#11904rbygrave wants to merge 2 commits intoapache:masterfrom
rbygrave wants to merge 2 commits intoapache:masterfrom
Conversation
Based on design discussion on Issue apache#11500, the proposal is to support `groupId:artifactId:version` format for Dependency, Exclusion and Mixin. This means that we can define dependencies in the form: ```xml <dependency id="groupId:artifactId:version" /> ``` Examples: ```xml <dependency id="org.slf4j:slf4j-api:2.0.17"/> ``` ```xml <dependency id="org.postgresql:postgresql:42.7.3"> <exclusions> <exclusion id="*:*"/> </exclusions> </dependency> ``` ```xml <mixin id="com.example.mixins:java-mixin:1.0.0" /> ```
Add more tests and make them more specific to the validation that is being tested by each test.
rbygrave
commented
Apr 8, 2026
| <superClass>Parent</superClass> | ||
| <fields> | ||
| <field xml.attribute="true" xml.tagName="id"> | ||
| <name>gav</name> |
Author
There was a problem hiding this comment.
Using field name gav with attribute name id ... in order to avoid the conflict with the existing Parent.getId()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on design discussion on Issue #11500, the proposal is to support
groupId:artifactId:versionformat for Dependency, Exclusion and Mixin elements.This means that we can define dependencies in the form:
Examples:
Notes:
Mixin has the xml attribute
idbut usesgavunderneath as the java field. This was because Mixin extends Parent which already hasgetId(). This was done to effectively work around the name clash withidthere.The validation is strict meaning that it's deemed invalid to mix the use of
idattribute with the usual gav elements. That is, when we useidit's deemed invalid to set agroupIdorartifactIdorversion. Maybe this strict validation could be lossened up but to me it seems reasonable to start with this strict validation initially.In Support groupId: artifactId: version format #11500 it was mentioned about also having attributes for
scopeandclassificationetc but that is omitted from this change. To specify scope we must still use the scope element.Following this checklist to help us incorporate your
contribution quickly and easily:
Note that commits might be squashed by a maintainer on merge.
This may not always be possible but is a best-practice.
mvn verifyto make sure basic checks pass.A more thorough check will be performed on your pull request automatically.
If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.
To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.