Skip to content

Fix NPE in DefaultModelBuilder #11922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
utafrali wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

Fix NPE in DefaultModelBuilder #11922

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion impl/maven-impl/src/main/java/org/apache/maven/impl/model/DefaultModelBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1398,7 +1398,7 @@ private Model readEffectiveModel() throws ModelBuilderException {
// path correctly if it was not set in the input model
if (inputModel.getParent() != null && inputModel.getParent().getRelativePath() == null) {
String relPath;
if (parentModel.getPomFile() != null && isBuildRequest()) {
if (parentModel.getPomFile() != null && inputModel.getPomFile() != null && isBuildRequest()) {
Copy link
Copy Markdown

@waterlx waterlx Apr 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just try to understand if it is as expected / a correct behavior to fall back inputModel's relPath to ".." when its getPomFile() is null.
Non-binding +1.

Copy link
Copy Markdown

@waterlx waterlx Apr 14, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comment has been resolved, but my "Resolve comment" is rejected by 401 (I have no idea why...). Please kindly move forward. Thank you!

relPath = inputModel
.getPomFile()
.getParent()
Expand Down