Fix profile property interpolation in repository URLs#11923
Closed
utafrali wants to merge 1 commit intoapache:masterfrom
Closed
Fix profile property interpolation in repository URLs#11923utafrali wants to merge 1 commit intoapache:masterfrom
utafrali wants to merge 1 commit intoapache:masterfrom
Conversation
Profile properties are injected after model validation, so skip expression validation for profile repository URLs to allow deferred property interpolation.
Author
|
closing, lmk if you want me to reopen with changes |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Profile-scoped properties weren't getting interpolated in repository URLs. The validator was checking for unresolved expressions before profile properties were injected, which caused it to reject valid property references.
Added a skipExpressionValidation flag so profile repositories can skip the expression check since property injection happens later in the process. Regular repos and distribution management still validate strictly. Includes a test case and verified with mvn verify locally.