Fix DefaultSettingsXmlFactory.write() always emitting location comments#11924
Open
utafrali wants to merge 1 commit intoapache:masterfrom
Open
Fix DefaultSettingsXmlFactory.write() always emitting location comments#11924utafrali wants to merge 1 commit intoapache:masterfrom
utafrali wants to merge 1 commit intoapache:masterfrom
Conversation
Mirror the pattern from DefaultModelXmlFactory.write() to disable location information by default and only enable it when an InputLocationFormatter is provided via the request. Closes apache#11899
|
@utafrali Hi! Thanks a lot for opening this pull request. I really appreciate the effort. Before moving forward, could you add unit tests to cover the changes? That helps ensure the update behaves as expected. |
This was referenced Apr 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aligns
DefaultSettingsXmlFactory.write()with the existing pattern inDefaultModelXmlFactory.write(). The writer now defaults toaddLocationInformation = falseand only enables it when anInputLocationFormatteris provided in the request.Previously the
SettingsStaxWriterconstructor defaultedaddLocationInformationtotrue, so every serialized settings document included location tracking comments regardless of whether a formatter was configured.Closes #11899