Fix ANSI colors not disabled when piped on JDK 25+#11927
Open
utafrali wants to merge 1 commit intoapache:masterfrom
Open
Fix ANSI colors not disabled when piped on JDK 25+#11927utafrali wants to merge 1 commit intoapache:masterfrom
utafrali wants to merge 1 commit intoapache:masterfrom
Conversation
On JDK 22+, System.console() returns non-null even when stdout is redirected. Use Console.isTerminal() via reflection to correctly detect piped output, falling back to the previous behavior on older JDK versions. Applied to both Maven 4 (LookupInvoker) and Maven 3 compat (MavenCli) code paths. Closes apache#11885
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On JDK 22+,
System.console()returns a non-null Console even when stdout is redirected to a pipe or file. This caused Maven to select the color message scheme when output was piped.Uses
Console.isTerminal()(JDK 22+) via reflection to correctly detect piped output. On JDK < 22, falls back to the previousSystem.console() != nullcheck.Applied to both Maven 4 (LookupInvoker) and Maven 3 compat (MavenCli) code paths.
Closes #11885