Skip to content

Fix mvn script expanding ${...} in CLI arguments #11983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ascheman wants to merge 1 commit into
base: master
Choose a base branch
from
+6 −8
Open

Fix mvn script expanding ${...} in CLI arguments #11983

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 6 additions & 8 deletions apache-maven/src/assembly/maven/bin/mvn
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -275,7 +275,7 @@ handle_args() {
handle_args "$@"
MAVEN_MAIN_CLASS=${MAVEN_MAIN_CLASS:=org.apache.maven.cling.MavenCling}

# Build command string for eval
# Build base command string for eval (only contains Maven-controlled values)
cmd="\"$JAVACMD\" \
$MAVEN_OPTS \
$MAVEN_DEBUG_OPTS \
Expand All @@ -289,14 +289,12 @@ cmd="\"$JAVACMD\" \
$LAUNCHER_CLASS \
$MAVEN_ARGS"

# Add remaining arguments with proper quoting
for arg in "$@"; do
cmd="$cmd \"$arg\""
done

if [ -n "$MAVEN_DEBUG_SCRIPT" ]; then
echo "[DEBUG] Launching JVM with command:" >&2
echo "[DEBUG] $cmd" >&2
echo "[DEBUG] $cmd" "$@" >&2
fi

eval exec "$cmd"
# User arguments ("$@") are passed directly to preserve literal values
# like ${...} Maven property placeholders without shell expansion.
# Only the base command uses eval for MAVEN_OPTS word splitting.
eval exec "$cmd" '"$@"'