Skip to content

Remove extracted Mac OS JLine binaries from Maven distro#11995

Merged
kwin merged 1 commit into
masterfrom
bugfix/remove-unpacked-macos-jline-binaries
Apr 28, 2026
Merged

Remove extracted Mac OS JLine binaries from Maven distro#11995
kwin merged 1 commit into
masterfrom
bugfix/remove-unpacked-macos-jline-binaries

Conversation

@kwin
Copy link
Copy Markdown
Member

@kwin kwin commented Apr 28, 2026

This prevents issues with the Quarantine flag otherwise preventing binaries with that flag from being executed.
The fallback automatically kicks in which loads the binary from the JAR (https://github.com/jline/jline3/blob/master/native/src/main/java/org/jline/nativ/JLineNativeLoader.java) which doesn't suffer from the quarantine flag.

This closes #10747

Following this checklist to help us incorporate your
contribution quickly and easily:

  • Your pull request should address just one issue, without pulling in other changes.
  • Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
  • Each commit in the pull request should have a meaningful subject line and body.
    Note that commits might be squashed by a maintainer on merge.
  • Write unit tests that match behavioral changes, where the tests fail if the changes to the runtime are not applied.
    This may not always be possible but is a best-practice.
  • Run mvn verify to make sure basic checks pass.
    A more thorough check will be performed on your pull request automatically.
  • You have run the Core IT successfully.

If your pull request is about ~20 lines of code you don't need to sign an
Individual Contributor License Agreement if you are unsure
please ask on the developers list.

To make clear that you license your contribution under
the Apache License Version 2.0, January 2004
you have to acknowledge this by using the following check-box.

@kwin kwin requested review from gnodet and slawekjaranowski April 28, 2026 10:52
@kwin kwin force-pushed the bugfix/remove-unpacked-macos-jline-binaries branch from 50ce74f to c2d15e2 Compare April 28, 2026 10:52
This prevents issues with the quarantine flag otherwise preventing
binaries with that flag from being executed
(https://www.cisa.gov/eviction-strategies-tool/info-attack/T1144).
The fallback automatically kicks in which loads the binary from the JAR
(https://github.com/jline/jline3/blob/master/native/src/main/java/org/jline/nativ/JLineNativeLoader.java)
which doesn't have the quarantine flag.

This closes #10747
@kwin kwin force-pushed the bugfix/remove-unpacked-macos-jline-binaries branch from c2d15e2 to 370a9d2 Compare April 28, 2026 10:57
@kwin kwin added the bug Something isn't working label Apr 28, 2026
@kwin kwin self-assigned this Apr 28, 2026
@kwin kwin added this to the 4.1.0 milestone Apr 28, 2026
@kwin kwin merged commit 1762cf6 into master Apr 28, 2026
20 of 21 checks passed
@kwin kwin deleted the bugfix/remove-unpacked-macos-jline-binaries branch April 28, 2026 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[MNG-8471] library load disallowed by system policy on Mac

3 participants