[MNG-7843] Allow glob patterns in dependency exclusions#1200
Merged
gnodet merged 3 commits intoapache:masterfrom Aug 29, 2023
Merged
Conversation
gnodet
force-pushed
the
MNG-7843-Allow-glob-patterns-in-dependency-exclusions
branch
from
4ee8e6d to
5688989
Compare
gnodet
force-pushed
the
MNG-7843-Allow-glob-patterns-in-dependency-exclusions
branch
from
5688989 to
00f61f8
Compare
elharo
requested changes
Jul 14, 2023
maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java
Outdated
Show resolved
Hide resolved
elharo
reviewed
Jul 14, 2023
Contributor
elharo
left a comment
elharo
left a comment
There was a problem hiding this comment.
In case, that wasn't clear the idea of globstars for dependency exclusion is useful. We just don't need to write more glob code to support this
elharo
requested changes
Jul 15, 2023
...ore/src/test/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilterTest.java
Show resolved
Hide resolved
maven-core/src/main/java/org/apache/maven/artifact/resolver/filter/ExclusionArtifactFilter.java
Outdated
Show resolved
Hide resolved
gnodet
force-pushed
the
MNG-7843-Allow-glob-patterns-in-dependency-exclusions
branch
from
adfe481 to
3ef12a8
Compare
cstamas
approved these changes
Aug 3, 2023
gnodet
force-pushed
the
MNG-7843-Allow-glob-patterns-in-dependency-exclusions
branch
from
89b7a00 to
e5c412c
Compare
Contributor
Author
@elharo are you fine with the changes that leverage the JDK glob matchers ? |
elharo
approved these changes
Aug 29, 2023
gnodet
deleted the
MNG-7843-Allow-glob-patterns-in-dependency-exclusions
branch
|
Resolve #9074 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excluding a bunch of dependencies is quite verbose. A simple glob pattern would really help.