Skip to content

[maven-4.0.x] improve align in dependency graph #12015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hboutemy merged 1 commit into from
May 5, 2026
+29 −28
Merged

[maven-4.0.x] improve align in dependency graph #12015

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
57 changes: 29 additions & 28 deletions src/graph/ReactorGraph.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -144,7 +144,7 @@ public static void main(String[] args) {
Files.write(Paths.get("target/graph/intermediary_graph.dot"), dotContent.getBytes());
System.out.println("Intermediary graph written to intermediary_graph.dot");

// Render graph to SVF
// Render graph to SVG
Graphviz.fromGraph(clusteredGraph)
.engine(Engine.FDP)
.render(Format.SVG).toFile(new File("target/graph/intermediary_graph.svg"));
Expand Down Expand Up @@ -185,40 +185,30 @@ private static MutableGraph generateHighLevelGraph(MutableGraph clusteredGraph,
MutableGraph cluster = entry.getValue();

String headerColor = clusterName.startsWith("Maven") ? "black" : "#808080"; // #808080 is a middle gray
String prefix;
switch (clusterName) {
case "MavenAPI": prefix = "../api/"; break;
case "MavenImplementation": prefix = "../impl/"; break;
case "MavenCompatibility": prefix = "../compat/"; break;
case "MavenResolver": prefix = "https://maven.apache.org/resolver/"; break;
default: prefix = null;
}

StringBuilder labelBuilder = new StringBuilder();
labelBuilder.append("<table border='0' cellborder='0' cellspacing='0'>");
labelBuilder.append("<tr><td bgcolor='")
labelBuilder.append("<table border='0' cellborder='0' cellspacing='0'>")
.append("<th border='1'><td cellpadding='5' bgcolor='")
.append(headerColor)
.append("'><font color='white'>")
.append("'><font color='white'><b>&nbsp;")
.append(key)
.append("</font></td></tr>");
.append("&nbsp;</b></font></td></th>");
cluster.nodes().stream().map(MutableNode::name).map(Label::toString).sorted()
.forEach(nodeName -> {
labelBuilder.append("<tr>");
String prefix = null;
switch (clusterName) {
case "MavenAPI": prefix = "../api/"; break;
case "MavenImplementation": prefix = "../impl/"; break;
case "MavenCompatibility": prefix = "../compat/"; break;
case "MavenResolver": prefix = "https://maven.apache.org/resolver/"; break;
}
labelBuilder.append("<tr><td align='left'");
if (prefix != null) {
labelBuilder.append("<td")
.append(" href=\"")
.append(prefix)
.append(nodeName)
.append("\"")
.append(" title=\"")
.append(nodeName)
.append("\"")
.append(" target=\"_parent\"")
.append(">")
.append(nodeName)
.append("</td>");
} else {
labelBuilder.append("<td>").append(nodeName).append("</td>");
labelBuilder.append(" href='").append(prefix).append(nodeName)
.append("' title='").append(nodeName).append("' target='_parent'");
}
labelBuilder.append("</tr>");
labelBuilder.append(">").append(nodeName).append("</td></tr>");
});
labelBuilder.append("</table>");

Expand Down Expand Up @@ -257,6 +247,17 @@ private static MutableGraph generateHighLevelGraph(MutableGraph clusteredGraph,
}
}

// force top group
MutableGraph topGroup = mutGraph("top")
.setDirected(true)
.graphAttrs().add(Rank.inSubgraph(Rank.RankType.SAME))
.add(
mutNode("MavenResolver"),
mutNode("MavenAPI"),
mutNode("MavenImplementation")
);
highLevelGraph.add(topGroup);

return highLevelGraph;
}

Expand Down
Loading