Fix #11920: skip expression validation for profile repository URLs

[gnodet]

Summary

• Skip uninterpolated expression validation for repository URLs and IDs inside profiles during raw model validation
• Profile properties are injected after raw model validation, so expressions like ${asf.staging} or ${env.MAVEN_MIRROR_URL} defined in profile properties/activation cannot be resolved at this stage
• Top-level repositories and distribution management repositories continue to be validated

Test plan

• Added test POM profile-with-property-in-repository-url.xml reproducing the Spark POM pattern (env var in profile repo URL + profile properties in plugin repo URLs)
• Added unit test profileWithPropertyInRepositoryUrl verifying no validation errors
• Existing tests for uninterpolated expressions in top-level repositories still pass
• Full module test suite passes (462 tests, 0 failures)

Closes #11920

🤖 Generated with Claude Code

Claude Code on behalf of Guillaume Nodet

[hboutemy]

do we know where/when/why the change was introduced?
checking history is part of clarity I'm checking by hand on such cases, having that in the typical automated description could be nice

[hboutemy]

seems it was part of #11140 backported to / introduced in 4.0.0-rc5
what is not clear to me is the comment in the reporting issue:

Maven 4.0.0-rc-5 reports the following error which is not reproducible by Maven 3.x

in Maven 3.x, there was no report, but was there interpolation? or just silent raw un-interpolated value?

[gnodet]

The uninterpolated expression validation was introduced in #11140 (commit 210dbdc, Oct 2025), backported to 4.0.x via #11210 — which landed in rc-5. The goal was to allow repository URL interpolation during model building and validate that all expressions are resolved afterward.

The problem is that this validation runs at the raw model stage (validateRawModel), where profile properties haven't been injected yet. For top-level repositories, the interpolation in readFileModel() resolves expressions using getEnhancedProperties() (which includes active profile properties). But for repositories inside inactive profiles — like maven-mirror activated by env.MAVEN_MIRROR_URL, or snapshots-and-staging requiring explicit -P activation — the profile properties aren't in scope, so expressions remain unresolved and the validator flags them as errors.

Regarding the Maven 3.x question: in Maven 3.x, there was no validation for uninterpolated expressions in repository URLs at all. The raw expressions were silently carried through. When a profile was activated, its properties got merged into the model during profile injection, and full model interpolation resolved them afterward. When a profile was NOT active, its repository definitions simply weren't included in the effective model, so the unresolved expressions were harmless. The interpolation always happened — just later in the pipeline, after profile activation.

Claude Code on behalf of Guillaume Nodet

[github-actions]

@gnodet Please assign appropriate label to PR according to the type of change.