Fix #12081: mvnup: use domtrip XML API on 4.0.x branch to align with master#12082
Merged
Conversation
Adds InheritedPluginDetectionTests and effective model warning test from maven-4.0.x branch (834daf2), converted from JDOM2 to domtrip. Also fixes log level for effective model analysis failures from debug to warning to avoid silently swallowing errors. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
May 19, 2026
gnodet
added a commit
that referenced
this pull request
May 19, 2026
rmannibucau
approved these changes
May 19, 2026
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This was referenced May 19, 2026
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
mvnupfrom JDOM to domtrip XML API on themaven-4.0.xbranch, aligning it withmasterThis eliminates the need to maintain two separate XML API implementations for mvnup across branches, enabling clean cherry-picks between
masterand4.0.x.Fixes #12081
Changes
pom.xml: Add domtrip dependency management (0.4.1), remove jdom2maven-cli/pom.xml: Replace jdom2 dependency with domtrip-core + domtrip-mavenJDomUtils.java,GAV.java,GAVUtils.java,UpgradeConstants.javaDomUtils.java(domtrip-based XML utilities)Test plan
**/mvnup/**filesClaude Code on behalf of Guillaume Nodet