Fix #11885: Disable ANSI colors when stdout is piped on JDK 22+ (backport)#12111
Merged
Merged
Conversation
…ted on JDK 22+ (apache#11887) Change ForcedSysOut to SysOut so that JLine properly checks whether stdout is a TTY before creating a system terminal. ForcedSysOut bypasses this check, which causes JLine to create a non-dumb terminal even when stdout is piped (since stdin is still a TTY), resulting in ANSI escape codes appearing in piped output on JDK 22+ where the FFM provider successfully creates a terminal from stdin alone. With SysOut, JLine detects that stdout is not a TTY and falls back to a dumb terminal, correctly disabling ANSI colors. Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
force-pushed
the
backport/maven-4.0.x/pr-11887
branch
from
7dd117b to
c9426e3
Compare
|
@gnodet Please assign appropriate label to PR according to the type of change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11887 to
maven-4.0.x.Summary
ForcedSysOuttoSysOutin JLine'sTerminalBuilderconfiguration so that JLine properly checks whether stdout is a TTY before creating a system terminalForcedSysOutcaused ANSI escape codes in piped output because stdin being a TTY was enough to create a non-dumb terminalFixes #11885
Claude Code on behalf of Guillaume Nodet