[backport maven-4.0.x] Fix logging setup/teardown order#12137
Merged
Conversation
Reorder ProjectBuildLogAppender registration in LookupInvoker so that it is added to the closeables list after the terminal setup. Since closeables are closed in reverse order (LIFO), this ensures the log sink is deregistered before the terminal is torn down, preventing StackOverflowErrors during shutdown. Closes #11901
gnodet
force-pushed
the
backport/11901-to-maven-4.0.x
branch
from
1b39285 to
faa69c9
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #11901
Cherry-pick of #11901 onto
maven-4.0.x.Original PR: #11901 - Fix logging setup/teardown order
Original author: @oehme
Target branch:
maven-4.0.xOriginal description
Reorder ProjectBuildLogAppender registration in LookupInvoker so that it is added to the closeables list after the terminal setup. Since closeables are closed in reverse order (LIFO), this ensures the log sink is deregistered before the terminal is torn down, preventing StackOverflowErrors during shutdown.
Relates to #11498