Upgrade domtrip from 1.5.1 to 1.5.2#12174
Open
gnodet wants to merge 1 commit into
Open
Conversation
Fixes blank line idempotency in addBlankLineBefore/addBlankLineAfter, which caused duplicate blank lines on repeated mvnup runs, leading to Spotless formatting failures. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
gnodet
added a commit
that referenced
this pull request
May 28, 2026
Cherry-pick from fix/domtrip-1.5.2 branch. Fixes blank line idempotency in addBlankLineBefore/addBlankLineAfter, which caused duplicate blank lines on repeated mvnup runs. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
addBlankLineBefore/addBlankLineAfter(domtrip PR #238)mvnupruns accumulate duplicate blank lines, causing Spotless formatting check failuresTest plan
Claude Code on behalf of Guillaume Nodet