Move repository expression validation from raw to effective model#12175
Open
gnodet wants to merge 1 commit into
Open
Move repository expression validation from raw to effective model#12175gnodet wants to merge 1 commit into
gnodet wants to merge 1 commit into
Conversation
Raw model validation checked for uninterpolated ${...} expressions in
repository IDs and URLs before parent POM properties were merged,
causing false positives for projects using parent-defined properties
(e.g. ${eclipseP2RepoId}).
Skip expression checks during raw validation for root-level
repositories (matching the existing behavior for profile and
distributionManagement repos) and instead validate in effective model
validation where all properties are fully resolved.
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate20EffectiveRepository), where parent properties have been merged and full interpolation is completeContext
Raw model validation runs before the parent POM is read (
doReadRawModel→validateRawModelhappens beforereadEffectiveModel→readParent). This means properties defined in parent POMs (e.g.,${eclipseP2RepoId}) are not available during raw validation, causing false positives.Profile and distributionManagement repositories already skipped expression checks for the same reason. This change extends that to root-level
repositoriesandpluginRepositories.Fixes: MNG-15012, MNG-14390, MNG-10104, MNG-13299, MNG-14733
Test plan
Generated with Claude Code