Skip to content

Fix #11973: Restore backward-compatible DefaultToolchain constructor #12238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gnodet wants to merge 1 commit into
base: master
Choose a base branch
from
+22 −0
Open

Fix #11973: Restore backward-compatible DefaultToolchain constructor #12238

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions compat/maven-compat/src/main/java/org/apache/maven/toolchain/DefaultToolchain.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@

import org.apache.maven.toolchain.model.ToolchainModel;
import org.slf4j.Logger;
import org.slf4j.LoggerFactory;

/**
* Default abstract toolchain implementation, to be used as base class for any toolchain implementation
Expand Down Expand Up @@ -68,6 +69,27 @@ protected DefaultToolchain(ToolchainModel model, String type, Logger logger) {
this.type = type;
}

/**
* @param model the model, must not be {@code null}
* @param logger the logger (ignored, an SLF4J logger is used instead)
* @deprecated Use {@link #DefaultToolchain(ToolchainModel, Logger)} with an SLF4J logger instead.
*/
@Deprecated(since = "4.0.0")
protected DefaultToolchain(ToolchainModel model, org.codehaus.plexus.logging.Logger logger) {
this(model, LoggerFactory.getLogger(DefaultToolchain.class));
}

/**
* @param model the model, must not be {@code null}
* @param type the type
* @param logger the logger (ignored, an SLF4J logger is used instead)
* @deprecated Use {@link #DefaultToolchain(ToolchainModel, String, Logger)} with an SLF4J logger instead.
*/
@Deprecated(since = "4.0.0")
protected DefaultToolchain(ToolchainModel model, String type, org.codehaus.plexus.logging.Logger logger) {
this(model, type, LoggerFactory.getLogger(DefaultToolchain.class));
}

@Override
public final String getType() {
return type != null ? type : model.getType();
Expand Down
Loading