Skip to content

Fix to prevent warning due to CI-friendly version in the parent pom #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
thorntonrp wants to merge 1 commit into from
Closed

Fix to prevent warning due to CI-friendly version in the parent pom #176

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions maven-core/src/main/java/org/apache/maven/project/DefaultProjectBuilder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -669,6 +669,9 @@ private void initProject( MavenProject project, Map<String, MavenProject> projec
else
{
Artifact parentArtifact = project.getParentArtifact();
if (parentArtifact.getVersion().matches("\\$\\{(revision|sha1|changelist)}")) {
parentArtifact.setVersion(project.getModel().getParent().getVersion());
Copy link
Member

@khmarbaise khmarbaise Sep 17, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First the pattern is not enough if we really allow to use ci friendly in parent cause things like this ${revision}-${changelist} are also possible which will not work with this pattern..Furthermore an integration test is needed for such things.

}
try
{
parent = build( parentArtifact, projectBuildingRequest ).getProject();
Expand Down